[riot-notifications] [RIOT-OS/RIOT] pkg/lvgl: remove internal thread (#16486)

Alexandre Abadie notifications at github.com
Thu May 20 13:15:27 CEST 2021

The RIOT community cares a lot about code quality.
Therefore, before describing what your contribution is about, we would like
you to make sure that your modifications are compliant with the RIOT
coding conventions, see https://github.com/RIOT-OS/RIOT/wiki/Coding-conventions.

### Contribution description

This PR is a small refactoring of the lvgl integration into RIOT: the internal thread used to trigger the lvgl task handler is removed and `lvgl_start` is renamed `lvgl_run`. It's still possible to run lvgl in its own thread, but this becomes the responsibility of the user  to do that.

There's one call to `lv_task_handler();` that is moved from `lvgl_init` to the beginning of `lvgl_run`. I'm suspecting that this change might fix the issue reported in #16471.

Since there's one thread less in `tests/pkg_lvgl` and `tests/pkg_lvgl_touch`, this PR frees up 2K of RAM on both.

Put here the description of your contribution:
- describe which part(s) of RIOT is (are) involved
- if it's a bug fix, describe the bug that it solves and how it is solved
- you can also give more information to reviewers about how to test your changes

### Testing procedure

- Green Murdock
- `tests/pkg_lvgl` and `tests/pkg_lvgl_touch` are still functional

Details steps to test your contribution:
- which test/example to compile for which board and is there a 'test' command
- how to know that it was not working/available in master
- the expected success test output

### Issues/PRs references

Might help with #16471 

Examples: Fixes #1234. See also #5678. Depends on PR #9876.

Please use keywords (e.g., fixes, resolve) with the links to the issues you
resolved, this way they will be automatically closed when your pull request
is merged. See https://help.github.com/articles/closing-issues-using-keywords/.

You can view, comment on, or merge this pull request online at:


-- Commit Summary --

  * pkg/lvgl: remove internal background thread
  * tests/pkg_lvgl*: adapt to new behavior

-- File Changes --

    M pkg/lvgl/contrib/lvgl.c (56)
    M pkg/lvgl/include/lvgl_riot.h (4)
    M tests/pkg_lvgl/main.c (4)
    M tests/pkg_lvgl_touch/main.c (2)

-- Patch Links --


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210520/4493e9e0/attachment.htm>

More information about the notifications mailing list