[riot-notifications] [RIOT-OS/RIOT] pkg/lvgl: remove internal thread (#16486)

Jean Pierre Dudey notifications at github.com
Thu May 20 19:58:28 CEST 2021


I've tested the code and it gives the same result, so I suspect is not the change done about `lv_task_handler`. I've dug a little bit on the auto initialization code and it seems to be that the dependency to `ili9341` was not present in the `esp32-wrover-kit/Makefile.dep` file when `disp_dev` is used. The LoadProhibitedException was caused because the a display was not found and tried to dereference a null pointer.

I've tested adding the dependency and works fine on master, on this PR on `pkg/lvgl/contrib.c` at line 157 (`lvgl_wakeup` called from `sysmon_task`) an `LoadProhibitedException` is thrown (because `lvgl_run` is called after `sysmon_create`/`sysmon_task`).

Built is as follows:

- `make -C tests/pkg_lvgl BOARD=esp32-wrover-kit BUILD_IN_DOCKER=1 flash`

With the patch

```patch
diff --git a/boards/esp32-wrover-kit/Makefile.dep b/boards/esp32-wrover-kit/Makefile.dep
index 29d6c99ba8..f6b6ba1bd4 100644
--- a/boards/esp32-wrover-kit/Makefile.dep
+++ b/boards/esp32-wrover-kit/Makefile.dep
@@ -1 +1,5 @@
+ifneq (,$(filter disp_dev,$(USEMODULE)))
+  USEMODULE += ili9341
+endif
+
 include $(RIOTBOARD)/common/esp32/Makefile.dep
```

That said, I like the approach of letting the user create their own thread for LVGL, it gives more flexibility.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/16486#issuecomment-845343534
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210520/125beb21/attachment.htm>


More information about the notifications mailing list