[riot-notifications] [RIOT-OS/RIOT] Package Arduino-SDI-12 (#16490)
J. David Ibáñez
notifications at github.com
Fri May 21 11:55:22 CEST 2021
The RIOT community cares a lot about code quality.
Therefore, before describing what your contribution is about, we would like
you to make sure that your modifications are compliant with the RIOT
coding conventions, see https://github.com/RIOT-OS/RIOT/wiki/Coding-conventions.
### Contribution description
Package the Arduino-SDI-12 library, see https://github.com/EnviroDIY/Arduino-SDI-12
SDI-12 is a serial communications protocol used by many sensors.
The first commit adds the new package and a test. The next commits add missing Arduino features in RIOT so the test builds for the mega2560 board.
This is a draft PR to gather feedback, since probably I've added some of these Arduino features in the wrong place, specially F_CPU.
Put here the description of your contribution:
- describe which part(s) of RIOT is (are) involved
- if it's a bug fix, describe the bug that it solves and how it is solved
- you can also give more information to reviewers about how to test your changes
### Testing procedure
Build the new test for the arduino-mega2560 board:
BOARD=arduino-mega2560 make -C tests/pkg_arduino_sdi_12/
It also builds for the arduino-uno board, except the program is too big.
I plan to make it work with the arduino-zero as well, and test with real hardware. But in the meanwhile I would like to gather feedback.
Details steps to test your contribution:
- which test/example to compile for which board and is there a 'test' command
- how to know that it was not working/available in master
- the expected success test output
### Issues/PRs references
Examples: Fixes #1234. See also #5678. Depends on PR #9876.
Please use keywords (e.g., fixes, resolve) with the links to the issues you
resolved, this way they will be automatically closed when your pull request
is merged. See https://help.github.com/articles/closing-issues-using-keywords/.
You can view, comment on, or merge this pull request online at:
-- Commit Summary --
* Package Arduino-SDI-12
* Define F_CPU, required by Arduino-SDI-12 package
* Arduino: add missing header files
* Arduino(atmega): add digitalPinTo* macros
* Arduino(atmega): add interrupts/noInterrupts macro
* Arduino: add missing cpp files
-- File Changes --
M boards/common/arduino-atmega/include/arduino_board.h (10)
M boards/common/arduino-atmega/include/arduino_pinmap.h (27)
M pkg/Kconfig (1)
A pkg/arduino_sdi_12/Kconfig (4)
A pkg/arduino_sdi_12/Makefile (9)
A pkg/arduino_sdi_12/Makefile.dep (1)
A pkg/arduino_sdi_12/Makefile.include (8)
A pkg/arduino_sdi_12/doc.txt (6)
A sys/arduino/Print.cpp (266)
A sys/arduino/Stream.cpp (318)
A sys/arduino/include/Print.h (93)
A sys/arduino/include/Printable.h (40)
A sys/arduino/include/Stream.h (129)
A sys/arduino/include/WString.h (229)
A tests/pkg_arduino_sdi_12/Makefile (5)
A tests/pkg_arduino_sdi_12/main.cpp (43)
-- Patch Links --
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the notifications