[riot-notifications] [RIOT-OS/RIOT] FIDO2 support in RIOT (#16489)

Nils Ollrogge notifications at github.com
Wed May 26 15:02:22 CEST 2021


@Ollrogge commented on this pull request.



> +#include <assert.h>
+
+#include "fmt.h"
+#include "xtimer.h"
+#include "byteorder.h"
+
+#include "fido2/ctap/transport/ctap_transport.h"
+#include "fido2/ctap.h"
+#include "fido2/ctap/ctap_utils.h"
+#include "fido2/ctap/ctap_cbor.h"
+#include "fido2/ctap/ctap_mem.h"
+
+#define ENABLE_DEBUG    (0)
+#include "debug.h"
+
+/*** main CTAP2 functions ***/

Yes all the main functions are defined in the spec. The helper functions are specific to this implementation. 
I think you are suggesting to define all methods defined in the CTAP spec publicly in `ctap.h`? This might be useful when the code is used for an internal authenticator that does not communicate over USB/NFC/BLE with the host. Otherwise only exposing `fido2_ctap_handle_request` should be enough, as the communication layers do not know which kind of CTAP method is being called.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/16489#discussion_r639703098
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210526/24f45e86/attachment.htm>


More information about the notifications mailing list