[riot-notifications] [RIOT-OS/RIOT] FIDO2 support in RIOT (#16489)

Nils Ollrogge notifications at github.com
Wed May 26 15:54:23 CEST 2021


@Ollrogge commented on this pull request.



> +    /* handle common error case */
+    switch (cmd) {
+    case CTAP_MAKE_CREDENTIAL:
+    case CTAP_GET_ASSERTION:
+    case CTAP_GET_NEXT_ASSERTION: {
+        if (locked()) {
+            return CTAP2_ERR_PIN_BLOCKED;
+        }
+
+        if (boot_locked()) {
+            return CTAP2_ERR_PIN_AUTH_BLOCKED;
+        }
+    }
+    }
+
+    switch (cmd) {

Just to make the code more readable and separate error handling from the CTAP method handling. I can remove the error handling switch statement and add it to the second one if that is better.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/16489#discussion_r639749440
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210526/ba80d232/attachment.htm>


More information about the notifications mailing list