[riot-notifications] [RIOT-OS/RIOT] FIDO2 support in RIOT (#16489)

Nils Ollrogge notifications at github.com
Mon May 31 18:25:44 CEST 2021


@Ollrogge commented on this pull request.



> +            DEBUG("Ctap parse options, unknown uption: %s \n", key);
+        }
+
+        cbor_value_advance(&map);
+        if (ret != CborNoError) {
+            return CTAP2_ERR_CBOR_PARSING;
+        }
+    }
+
+    return CTAP2_OK;
+}
+
+static int parse_allow_list(CborValue *it, CborValue *allow_list,
+                            size_t *allow_list_len)
+{
+    return parse_exclude_list(it, allow_list, allow_list_len);

Why is that odd ? This way I can give the functions an obvious name. A more general name matching both cases might make things less understandable, no ?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/16489#discussion_r642590353
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210531/4a4d9019/attachment.htm>


More information about the notifications mailing list