[riot-notifications] [RIOT-OS/RIOT] FIDO2 support in RIOT (#16489)

Nils Ollrogge notifications at github.com
Mon May 31 18:51:42 CEST 2021


@Ollrogge commented on this pull request.



> +        ret = cbor_value_advance(&map);
+        if (ret != CborNoError) {
+            return CTAP2_ERR_CBOR_PARSING;
+        }
+    }
+
+    /* id is mandatory */
+    if (required_parsed != 1) {
+        return CTAP2_ERR_MISSING_PARAMETER;
+    }
+
+    return CTAP2_OK;
+}
+
+/* parse PublicKeyCredentialUserEntity dictionary */
+static int parse_user(CborValue *it, ctap_user_ent_t *user)

I could put common parsing functionality of `parse_rp` and `parse_user` into a function but this would make the code less readable and additional logic would be needed to differ between if `ctap_user_ent_t` or `ctap_rp_ent_t` is being parsed.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/16489#discussion_r642600111
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210531/ce960e51/attachment.htm>


More information about the notifications mailing list