[riot-notifications] [RIOT-OS/RIOT] FIDO2 support in RIOT (#16489)

Nils Ollrogge notifications at github.com
Mon May 31 19:30:40 CEST 2021


@Ollrogge commented on this pull request.



> +            if (ret != CTAP2_OK) {
+                return ret;
+            }
+        }
+
+        if (rks_exist(exclude_list, req.exclude_list_len, req.rp.id,
+                      req.rp.id_len)) {
+#if !IS_ACTIVE(CONFIG_FIDO2_CTAP_DISABLE_UP)
+            fido2_ctap_utils_user_presence_test();
+#endif
+            return CTAP2_ERR_CREDENTIAL_EXCLUDED;
+        }
+    }
+
+    /* setting user presence (up) is not valid for this command */
+    if (req.options.up != -1) {

Up is mandatory for `make_credential`.  I added further documentation to clarify this

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/16489#discussion_r642612992
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210531/9d25a7dd/attachment.htm>


More information about the notifications mailing list