[riot-notifications] [RIOT-OS/RIOT] makefiles/boot/riotboot.mk: add variable for required env variables (#16560)

Francisco notifications at github.com
Wed Sep 1 10:01:28 CEST 2021


@fjmolinas commented on this pull request.



>  # IOTLAB_NODE is passed so that FLASHFILE is also set in the recursive make call
 # when PROGRAMMER=iotlab
+RIOTBOOT_BOOTLOADER_VARS = \
+    BOARD \
+    EXTERNAL_BOARD_DIRS \
+    DEBUG_ADAPTER_ID \
+    PROGRAMMER \
+    PROGRAMMER_QUIET \
+    IOTLAB_NODE \
+    #
+RIOTBOOT_BOOTLOADER_ENV_VARS := $(strip $(foreach varname,$(RIOTBOOT_BOOTLOADER_VARS), \
+    $(if $(filter file environment command,$(origin $(varname))), \

Seems its a matter of the order of inclusion of the Makefiles and that I'm using `:=` for the assignment, But now that I look at it quoting is not a good thing in all cases, since we are sometimes checking explictly like `ifeq (0,$(PROGRAMMER_QUIET))`, this change might not be worth it if handling all these cases, since I'll have to quote some and not others...

(thanks for taking a deeper look into this)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/16560#discussion_r699976067
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210901/b06fbc3c/attachment.htm>


More information about the notifications mailing list