[riot-notifications] [RIOT-OS/RIOT] sys/net/dhcpv6: Refactor DHCPv6 client (#16728)

Martine Lenders notifications at github.com
Wed Sep 1 11:18:37 CEST 2021


@miri64 approved this pull request.

ACK. Confirmed that this code mostly moves code and removes code duplication. I ran both `tests/gnrc_dhcpv6_client` and `tests/gnrc_dhcpv6_client_6lbr` and both still succeed (with the usual OS-specific adaptations I need to do with Arch:

```diff
diff --git a/tests/gnrc_dhcpv6_client/Makefile b/tests/gnrc_dhcpv6_client/Makefile
index 5c8b0c0d89..98ccf027d4 100644
--- a/tests/gnrc_dhcpv6_client/Makefile
+++ b/tests/gnrc_dhcpv6_client/Makefile
@@ -39,10 +39,13 @@ TEST_ON_CI_BLACKLIST += all
 
 include $(RIOTBASE)/Makefile.include
 
-.PHONY: dhcpv6_server
+.PHONY: dhcpv6_server sudo
 
-dhcpv6_server:
-	$(CURDIR)/dhcpv6_server.sh $(DHCPV6_SERVER_PORT) $(CURDIR)/kea-dhcp6.conf
+dhcpv6_server: sudo
+	sudo $(CURDIR)/dhcpv6_server.sh $(DHCPV6_SERVER_PORT) $(CURDIR)/kea-dhcp6.conf
+
+sudo:
+	@sudo true
 
 ifeq (,$(filter native,$(BOARD)))
 .PHONY: ethos
diff --git a/tests/gnrc_dhcpv6_client/kea-dhcp6.conf b/tests/gnrc_dhcpv6_client/kea-dhcp6.conf
index b42eade5bd..a2a8ab429c 100644
--- a/tests/gnrc_dhcpv6_client/kea-dhcp6.conf
+++ b/tests/gnrc_dhcpv6_client/kea-dhcp6.conf
@@ -27,20 +27,5 @@
                          "prefix-len": 33,
                          "delegated-len": 64 } ] }
     ]
-  },
-"Logging":
-{
-  "loggers": [
-    {
-      "name": "kea-dhcp6",
-      "output_options": [
-          {
-            "output": "stderr"
-          }
-      ],
-      "severity": "INFO",
-      "debuglevel": 0
-    }
-  ]
-}
+  }
 }
```

)



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/16728#pullrequestreview-743683780
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210901/7b866f56/attachment.htm>


More information about the notifications mailing list