[riot-notifications] [RIOT-OS/RIOT] drivers/periph_spi: let spi_acquire return void (#15902)

Dylan Laduranty notifications at github.com
Wed Sep 1 14:03:54 CEST 2021


@dylad commented on this pull request.



>  static inline int _acquire(const bmx280_t *dev)
 {
-    if (spi_acquire(BUS, CS, MODE, CLK) != SPI_OK) {
-        return BMX280_ERR_BUS;
-    }
-    return BMX280_OK;
+    spi_acquire(BUS, CS, MODE, CLK);
 }

Either let `_acquire` returns void or re-add `return BMX280_OK` for consistency

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/15902#pullrequestreview-743835200
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210901/29dfcd1f/attachment.htm>


More information about the notifications mailing list