[riot-notifications] [RIOT-OS/RIOT] tests/gnrc_dhcpv6_client: Fix for newer Kea versions and remove sudo requirement (#16792)

Karl Fessel notifications at github.com
Wed Sep 1 15:52:44 CEST 2021


@kfessel commented on this pull request.

we may as well leave the shell if its no longer used

> +    cd "$TMPDIR" || exit 1
+    KEA_PIDFILE_DIR=. KEA_LOCKFILE_DIR=. \
+        kea-dhcp6 -p "$1" -c "$config"

```suggestion
    cd "$TMPDIR" || exit 1
    KEA_PIDFILE_DIR=. KEA_LOCKFILE_DIR=. \
        kea-dhcp6 -p "$1" -c "$config" &
```

>  }
 
 # no need to kill from external, kea handles double instances gracefully
-_dhcpv6_server $1 $2 &
+_dhcpv6_server "$1" "$2" &

```suggestion
_dhcpv6_server "$1" "$2"
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/16792#pullrequestreview-743955753
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210901/35464a22/attachment.htm>


More information about the notifications mailing list