[riot-notifications] [RIOT-OS/RIOT] tests/gnrc_dhcpv6_client: honor configured IFACE in Kea config (#16796)
notifications at github.com
Wed Sep 1 17:02:50 CEST 2021
The RIOT community cares a lot about code quality.
Therefore, before describing what your contribution is about, we would like
you to make sure that your modifications are compliant with the RIOT
coding conventions, see https://github.com/RIOT-OS/RIOT/wiki/Coding-conventions.
### Contribution description
Currently, Kea will only start in `tests/gnrc_dhcpv6_client` properly, when `IFACE` is set to `tapbr0`. With this change, the Kea config honors the value of the `IFACE` variable.
Put here the description of your contribution:
- describe which part(s) of RIOT is (are) involved
- if it's a bug fix, describe the bug that it solves and how it is solved
- you can also give more information to reviewers about how to test your changes
### Testing procedure
Create a bridge typically not used with RIOT e.g.
dist/tools/tapsetup/tapsetup -b tapbr1
and start the test with that interface
IFACE=tapbr1 make -C tests/gnrc_dhcpv6_client flash -j test-with-config
without this change the test will fail and Kea will complain, that `tapbr0` does not exist. With this change the test should pass.
Details steps to test your contribution:
- which test/example to compile for which board and is there a 'test' command
- how to know that it was not working/available in master
- the expected success test output
### Issues/PRs references
Follow-up on #16792.
Examples: Fixes #1234. See also #5678. Depends on PR #9876.
Please use keywords (e.g., fixes, resolve) with the links to the issues you
resolved, this way they will be automatically closed when your pull request
is merged. See https://help.github.com/articles/closing-issues-using-keywords/.
You can view, comment on, or merge this pull request online at:
-- Commit Summary --
* tests/gnrc_dhcpv6_client: honor configured IFACE in Kea config
-- File Changes --
M tests/gnrc_dhcpv6_client/Makefile (4)
M tests/gnrc_dhcpv6_client/dhcpv6_server.sh (13)
-- Patch Links --
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the notifications