[riot-notifications] [RIOT-OS/RIOT] tests/gnrc_dhcpv6_client: honor configured IFACE in Kea config (#16796)

Karl Fessel notifications at github.com
Wed Sep 1 18:26:04 CEST 2021


@kfessel commented on this pull request.



>  
     # only used `mktemp` with dry-run above to get temp directory name, so we
     # still need to create the directory
     mkdir -p "${TMPDIR}"
-    if _kea_version_lesser_1_7_10; then
-        config=$2
-    else
+    sed "s/\"tapbr0\"/\"${IFACE}\"/" "$2" > "${CONFIG}"

I think think this makes the conf file a template -> i think this should be more visible to the person looking at it
```suggestion
    sed "s/\"--IFACE--\"/\"${IFACE}\"/" "$2" > "${CONFIG}"
```
and since python is used for one case maybe it would be good for both and have it in a script instead of inline


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/16796#pullrequestreview-744147295
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210901/722031e0/attachment.htm>


More information about the notifications mailing list