[riot-notifications] [RIOT-OS/RIOT] sys/net/dhcpv6: Add stateless DHCPv6 (#16731)

Martine Lenders notifications at github.com
Thu Sep 2 12:41:56 CEST 2021


@miri64 commented on this pull request.



>  static uint32_t t2, rebind_time;
 static uint32_t transaction_start;
 static uint32_t transaction_id;
 static uint8_t duid_len = sizeof(dhcpv6_duid_l2_t);
+uint8_t configuration_mode = DHCPV6_CLIENT_CONF_MODE_INACTIVE;

```suggestion
static uint8_t configuration_mode = DHCPV6_CLIENT_CONF_MODE_INACTIVE;
```

> +CFLAGS += -DCONFIG_GNRC_IPV6_NIB_SLAAC=1
+CFLAGS += -DCONFIG_GNRC_IPV6_NIB_ARSM=1

Please use Kconfig to configure these by adding the appropriate `app.config` to the application's directory.

> +    return sniffer
+
+
+def wait_for_dhcpv6_pkt(iface, sniffer=None, timeout=5):
+    if sniffer is None:
+        sniffer = start_sniffer(iface, "udp and dst port 547", count=3000)
+    sniffer.join(timeout=timeout)
+    if sniffer.results is None:
+        raise TimeoutError("Sniffing for DHCPv6 traffic timed out")
+    return [p for p in sniffer.results
+            # filter out packets only belonging to stop_filter if it existed
+            if sniffer.kwargs.get("stop_filter") is None or
+            sniffer.kwargs["stop_filter"](p)][-1]
+
+
+def wait_for_icmpv6_pkt(iface, sniffer=None, timeout=15):

Did not look into the test code in detail, but might it make sense to use a [Scapy Automaton](https://scapy.readthedocs.io/en/latest/advanced_usage.html#first-example) for this?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/16731#pullrequestreview-744897839
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210902/2d43751c/attachment.htm>


More information about the notifications mailing list