[riot-notifications] [RIOT-OS/RIOT] tests/gnrc_dhcpv6_client: honor configured $IFACE in Kea config (#16796)

Martine Lenders notifications at github.com
Thu Sep 2 15:01:32 CEST 2021


@miri64 commented on this pull request.



>  
     # only used `mktemp` with dry-run above to get temp directory name, so we
     # still need to create the directory
     mkdir -p "${TMPDIR}"
-    if _kea_version_lesser_1_7_10; then
-        config=$2
-    else
+    sed "s/\"tapbr0\"/\"${IFACE}\"/" "$2" > "${CONFIG}"

> But can add a comment, to alleviate potential confusion.

Arghs, while Kea supports comments in their config, the JSON parser of python does not. So I added the doc on that to the test's README (and fixed it in the process)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/16796#discussion_r701059208
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210902/438eacb5/attachment-0001.htm>


More information about the notifications mailing list