[riot-notifications] [RIOT-OS/RIOT] gnrc/ipv6_auto_subnets: relax topology requirements (#16750)

Martine Lenders notifications at github.com
Thu Sep 2 16:55:54 CEST 2021


@miri64 commented on this pull request.



> +static void _configure_subnets(uint8_t subnets, uint8_t start_idx, gnrc_netif_t *upstream,
+#if IS_USED(MODULE_GNRC_IPV6_AUTO_SUBNETS_SIMPLE)
+                               const ndp_opt_pi_t *pio
+#else
+                               const struct pio_cache *pio
+#endif

Please don't do it this way. I know I did that too in the NIB, but it is horrible. It could be a nice solution to inherit `struct pio_cache` from `ndp_opt_pi_t` and only add additional fields needed when the pseudo-module is compiled in. If that is too wasteful for your liking, I would prefer different functions (or at least different _complete_ function declarations) for both modules. That way you also don't have some weird typing issues that might show up later, because the type within the function depends on the compile-time config.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/16750#pullrequestreview-745171276
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210902/34033e6e/attachment-0001.htm>


More information about the notifications mailing list