[riot-notifications] [RIOT-OS/RIOT] gnrc/ipv6_auto_subnets: relax topology requirements (#16750)

benpicco notifications at github.com
Thu Sep 2 21:31:50 CEST 2021


@benpicco commented on this pull request.



> +static void _configure_subnets(uint8_t subnets, uint8_t start_idx, gnrc_netif_t *upstream,
+#if IS_USED(MODULE_GNRC_IPV6_AUTO_SUBNETS_SIMPLE)
+                               const ndp_opt_pi_t *pio
+#else
+                               const struct pio_cache *pio
+#endif

You're right, when considering padding I'm only saving 4 bytes with the custom `struct pio_cache`.
The added ROM cost of manually copying the struct elements would outweigh that. 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/16750#discussion_r701365666
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210902/0f1919d6/attachment.htm>


More information about the notifications mailing list