[riot-notifications] [RIOT-OS/RIOT] makefiles: Reject `2>&1 >/dev/null`, and weed out remaining offenders (#16806)

benpicco notifications at github.com
Fri Sep 3 13:34:33 CEST 2021


@benpicco commented on this pull request.



> @@ -57,7 +57,7 @@ endif
 IOTLAB_AUTH ?= $(HOME)/.iotlabrc
 IOTLAB_USER ?= $(shell cut -f1 -d: $(IOTLAB_AUTH))
 
-ifneq (0,$(shell command -v iotlab-experiment -h 2>&1 > /dev/null ; echo $$?))
+ifneq (0,$(shell command -v iotlab-experiment -h > /dev/null 2>&1; echo $$?))

```suggestion
ifneq (0,$(shell command -v iotlab-experiment -h > /dev/null; echo $$?))
```
why not leave stderr in place?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/16806#pullrequestreview-746009074
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210903/9750f793/attachment.htm>


More information about the notifications mailing list