[riot-notifications] [RIOT-OS/RIOT] make: add capability to check config for `test-with-config` (#16795)

Karl Fessel notifications at github.com
Fri Sep 3 16:27:50 CEST 2021


@kfessel commented on this pull request.

this is also long and difficult to read -> comment to explain

> @@ -40,17 +40,34 @@ test-as-root/available:
 	$(Q)test -n "$(strip $(TESTS_AS_ROOT))"
 
 # Tests that require specific configuration
-.PHONY: test-with-config test-with-config/available
-TESTS_WITH_CONFIG ?= $(foreach file,$(wildcard $(APPDIR)/tests-with-config/*[^~]),\
-                        $(shell test -f $(file) -a -x $(file) && echo $(file)))
+.PHONY: test-with-config test-with-config/available test-with-config/check-config
+TESTS_WITH_CONFIG ?= $(filter-out $(APPDIR)/tests-with-config/check-config%,\

```suggestion
# scripts for testing without the configuration checking scripts
TESTS_WITH_CONFIG ?= $(filter-out $(APPDIR)/tests-with-config/check-config%,\
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/16795#pullrequestreview-746166744
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210903/580e56cb/attachment.htm>


More information about the notifications mailing list