[riot-notifications] [RIOT-OS/RIOT] cpu/nrf9160: add twi and spi support (#16814)

benpicco notifications at github.com
Mon Sep 6 11:53:34 CEST 2021


@benpicco commented on this pull request.



> +        .scl = 31,
+        .sda = 30,

This is 

```suggestion
        .scl = GPIO_PIN(0, 31),
        .sda = GPIO_PIN(0, 30),
```

right? 

> +#ifdef ERRATA_SPI_SINGLE_BYTE_WORKAROUND
+        .ppi = 0,
+#endif

This is only relevant for NRF52832
```suggestion
```

> @@ -1,3 +1,17 @@
 MODULE = nrf5x_common_periph
 
+# Select the specific implementation for `periph_i2c`
+ifneq (,$(filter periph_i2c,$(USEMODULE)))
+  ifneq (,$(filter $(CPU_FAM),nrf52 nrf9160))

so the new implementation is for *both* nrf52 and nrf9160?
What happens with nrf51?

> + *
+ *              I2C is called TWI (Two Wire Interface) in the datasheets from Nordic
+ *
+ * @author      Dylan Laduranty <dylan.laduranty at mesotic.com>
+ *
+ * @}
+ */
+
+#include <assert.h>
+
+#include "cpu.h"
+#include "periph_cpu.h"
+#include "periph_conf.h"
+
+static spi_twi_irq_cb_t _irq[SPIM_COUNT];
+static void *_irq_arg[SPIM_COUNT];

Isn't `SPIM_COUNT` the number of *SPI* Master interfaces?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/16814#pullrequestreview-747039205
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210906/28a0dab9/attachment.htm>


More information about the notifications mailing list