[riot-notifications] [RIOT-OS/RIOT] cpu/nrf9160: add twi and spi support (#16814)

Francisco notifications at github.com
Tue Sep 7 08:57:10 CEST 2021


> hm looks like you need something like
> 
> ```diff
> --- a/pkg/nimble/Makefile.dep
> +++ b/pkg/nimble/Makefile.dep
> @@ -42,7 +42,7 @@ endif
>  # nimble controller dependencies
>  ifneq (,$(filter nimble_controller,$(USEMODULE)))
>    USEMODULE += nimble_transport_ram
> -  ifneq (,$(filter nrf5%,$(CPU_FAM)))
> +  ifneq (,$(filter nrf9160 nrf5%,$(CPU_FAM)))
>      USEMODULE += nimble_drivers_nrf5x
>    endif
>  endif
> ```

Hmm no you would need more than that, this is based on the fact that `mynewt-nimble` needs to initialize nrf5 timers see https://github.com/apache/mynewt-nimble/blob/master/porting/nimble/src/hal_timer.c, and so we do the same when using `mynewt-core` for this. But AFAIKT in nimble this is only for nrf52 so no guarantees this works for `nrf9*`. Please apply this patch instead:

```diff
diff --git a/pkg/nimble/Makefile.dep b/pkg/nimble/Makefile.dep
index 07d4caf282..45e8d47ec8 100644
--- a/pkg/nimble/Makefile.dep
+++ b/pkg/nimble/Makefile.dep
@@ -18,7 +18,9 @@ USEMODULE += nimble_porting_nimble
 ifneq (,$(filter mynewt-core,$(USEPKG)))
   USEMODULE += mynewt-core_os
   USEMODULE += mynewt-core_util
-  USEMODULE += mynewt-core_nrf5x_hal
+  ifneq (,$(filter nrf5%,$(CPU)))
+    USEMODULE += mynewt-core_nrf5x_hal
+  endif
 else
   # uwb-% requires mynewt-core so is incompatible with nimble_npl_riot
   ifeq (,$(filter uwb%,$(USEPKG)))
diff --git a/pkg/uwb-core/Makefile.dep b/pkg/uwb-core/Makefile.dep
index b4f0c0355a..fd59855a7a 100644
--- a/pkg/uwb-core/Makefile.dep
+++ b/pkg/uwb-core/Makefile.dep
@@ -25,7 +25,7 @@ endif
 ifneq (,$(filter uwb-core_dpl,$(USEMODULE)))
   USEPKG += mynewt-core
   USEMODULE += mynewt-core_os
-  ifneq (,$(filter nrf%,$(CPU)))
+  ifneq (,$(filter nrf5%,$(CPU)))
     USEMODULE += mynewt-core_nrf5x_hal
   endif
 endif
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/16814#issuecomment-914042161
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210906/afa1e832/attachment.htm>


More information about the notifications mailing list