[riot-notifications] [RIOT-OS/RIOT] sys/net/application_layer: add telnet server module & example (#16723)

Martine Lenders notifications at github.com
Tue Sep 7 11:37:29 CEST 2021


@miri64 commented on this pull request.



> +#ifndef TELNET_PORT
+#define TELNET_PORT (23)

```suggestion
#ifndef CONFIG_TELNET_PORT
#define CONFIG_TELNET_PORT (23)
```

And add a `KConfig` file to the modules directory, please (if at least for `CONFIG_TELNET_TCP_QUEUE_SIZE`), not sure if the port needs to be configurable.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/16723#pullrequestreview-747763156
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210907/90702f6b/attachment.htm>


More information about the notifications mailing list