[riot-notifications] [RIOT-OS/RIOT] tests/gnrc_dhcpv6_client: add script to check if $IFACE exists (#16797)

Karl Fessel notifications at github.com
Tue Sep 7 12:48:41 CEST 2021


@kfessel commented on this pull request.

I think a comment would be nice for a future reader of this Makefile

> @@ -41,7 +41,11 @@ include $(RIOTBASE)/Makefile.include
 
 .PHONY: dhcpv6_server
 
-dhcpv6_server: IFACE := ${IFACE}
+$(call target-export-variables,dhcpv6_server test-with-config/check-config,IFACE)

```suggestion
# export IFACE variable to environment of dhcpv6_server and test-with-config/check-config rules
$(call target-export-variables,dhcpv6_server test-with-config/check-config,IFACE)
```
I think this improves the understanding of this call

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/16797#pullrequestreview-747827646
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210907/5bb80858/attachment.htm>


More information about the notifications mailing list