[riot-notifications] [RIOT-OS/RIOT] cpu: call cpu_init() from startup code, not from board (#16055)

Kaspar Schleiser notifications at github.com
Wed Sep 8 14:37:23 CEST 2021


BTW, I'm not happy with renaming cpu_init() to soc_init() "so we can introduce a no-op cpu_init() for compatibility".
There might be some external boards, which now need to be updated. But *we* constantly look at the code, and I don't like renaming unless it has a very good reason. Pausing for a couple of weeks and then having to update my understanding to new function names  (like "soc_init()") is quite some mental burden.

Also, this works once. What happens if we change how cpu_init() is used again? Rename to "processor_init()", so we can introduce a no-op "soc_init()" for compatibility?

IMO, let's just change where this is called, and add a big note to the release notes...

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/16055#issuecomment-915201106
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210908/78df4141/attachment.htm>


More information about the notifications mailing list