[riot-notifications] [RIOT-OS/RIOT] pkg/nimble/netif: add nimble_netif_accept_direct() (#16603)

Francisco notifications at github.com
Thu Sep 9 14:30:07 CEST 2021


@fjmolinas commented on this pull request.

Looks good, nice to have this one added, some small questions.

>  {
-    assert(ad);

Why can this now be NULL?

> +int nimble_netif_accept(const uint8_t *ad, size_t ad_len,
+                        const struct ble_gap_adv_params *adv_params)
+{
+    return _accept(ad, ad_len, NULL, BLE_HS_FOREVER, adv_params);
+}

A bit unrelated but why does this not have a timeout?

> +    /* start advertising directed advertising with the given BLE address */
+    res = nimble_netif_accept_direct(&addr, BLE_HS_FOREVER, &_adv_params);
+    if (res != NIMBLE_NETIF_OK) {
+        printf("err: unable to start directed advertising (%i)\n", res);
+    }
+    else {
+        puts("success: started to send directed advertisements");
+    }

Does it make sense to add a timeout?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/16603#pullrequestreview-750265409
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210909/9894e71d/attachment.htm>


More information about the notifications mailing list