[riot-notifications] [RIOT-OS/RIOT] gnrc/sock: recv avoid spinning xtimer (#16831)

benpicco notifications at github.com
Thu Sep 9 16:05:07 CEST 2021


@benpicco commented on this pull request.



> @@ -117,6 +117,12 @@ ssize_t gnrc_sock_recv(gnrc_sock_reg_t *reg, gnrc_pktsnip_t **pkt_out,
 #ifdef MODULE_XTIMER
     xtimer_t timeout_timer;
 
+    /* xtimer_spin would make this never receive anything avoid it by setting
+    /* the minimal not spinning timeout */
+    if (timeout < XTIMER_BACKOFF){

```suggestion
    if (timeout < XTIMER_BACKOFF) {
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/16831#pullrequestreview-750393723
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210909/95114b41/attachment.htm>


More information about the notifications mailing list