[riot-notifications] [RIOT-OS/RIOT] pkg/uwb*: add Kconfig dependency modelling (#16780)

Leandro Lanzieri notifications at github.com
Fri Sep 10 14:33:28 CEST 2021


@leandrolanzieri commented on this pull request.



> +choice
+    bool "Backend"
+    depends on MODULE_NETDEV_DEFAULT
+    default NRF802154
+    default NRFBLE
+
+config NRF802154
+    bool "nrf802154"
+    select MODULE_NRF802154
+
+config NRFBLE
+    bool "nrfble"
+    select MODULE_NRFBLE
+
+config NRFMIN
+    bool "nrfmin"
+    select MODULE_NRFMIN
+
+endchoice

I think we should improve documentation of this, just "Backend" seems strange. I'm not sure this actually depends on netdev_default but is activated when that module is there. I think we may be missing some driver switch?

> +config MODULE_SAUL_DEFAULT
+    select MODULE_LIS2DH12

I think this should be done via selecting features.

> +config MODULE_PERIPH
+    bool
+    default y
+    help
+        nrf52 common peripheral code

Do we need to re-define this symbol? 

> +# directory for more details.
+#
+
+config MODULE_PERIPH
+    bool
+    default y
+    help
+        nrf52 common peripheral code
+
+config MODULE_PERIPH_UART_NONBLOCKING
+    depends on HAS_PERIPH_UART_NONBLOCKING
+    depends on MODULE_PERIPH_UART
+    select MODULE_TSRB
+
+config MODULE_PERIPH_SPI
+    select MODULE_PERIPH_GPIO_IRQ if CPU_MODEL_NRF52832XXAA

```suggestion
    depends on HAS_PERIPH_SPI
    select MODULE_PERIPH_GPIO_IRQ if CPU_MODEL_NRF52832XXAA
```

> @@ -0,0 +1,26 @@
+# Copyright (c) 2021 INRIA
+#
+# This file is subject to the terms and conditions of the GNU Lesser
+# General Public License v2.1. See the file LICENSE in the top level
+# directory for more details.
+#
+
+config PACKAGE_UWB-DW1000
+    bool "Decawave dw1000 driver package"
+    select MODULE_UWB-DW1000_HAL
+    imply PACKAGE_UWB-CORE

`imply` will not guarantee that the module is there, it should either be `depends on` or `select`. 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/16780#pullrequestreview-751352359
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210910/acd01ee2/attachment.htm>


More information about the notifications mailing list