[riot-notifications] [RIOT-OS/RIOT] sys/posix: add module posix_netdb (#16853)

Martine Lenders notifications at github.com
Tue Sep 14 15:57:20 CEST 2021


@miri64 requested changes on this pull request.

> I also added the option to use posix sockets for the existing `sock_dns` module. Without using posix sockets I had extremely poor success rates for address resolution (approximately 1 out of 20).

NACK. 1. We rather should find the reason, why `sock_udp` performs so poorly compared to POSIX sockets (which below take use `sock_udp`, so this fact seems weird to me). 2. `sock_dns` using POSIX sockets turns everything on its head, now we have a `sock` module using POSIX sockets using a `sock` module. Conceptually alone this sounds very dirty.



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/16853#pullrequestreview-753984234
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210914/6dd0d980/attachment.htm>


More information about the notifications mailing list