[riot-notifications] [RIOT-OS/RIOT] cc2538_rf: remove RX Busy detection in request_set_trx_state (#16821)

benpicco notifications at github.com
Wed Sep 15 00:14:59 CEST 2021


@benpicco commented on this pull request.



>      RFCORE_XREG_RFIRQM1 = TXDONE | CSP_STOP | TXACKDONE;
-    RFCORE_XREG_RFIRQM0 = RXPKTDONE | FIFOP | SFD;
+    RFCORE_XREG_RFIRQM0 = RXPKTDONE | SFD;

```suggestion
    _enable_irq();
```

> @@ -226,8 +255,11 @@ static int _read(ieee802154_dev_t *dev, void *buf, size_t size, ieee802154_rx_in
     }
 
 end:
-    /* Enable RX Chain */
-    RFCORE_XREG_FRMCTRL0 &= ~CC2538_FRMCTRL0_RX_MODE_DIS;
+    /* Enable RX Chain only if the state is still RX_ON */
+    if (cc2538_state == CC2538_STATE_READY
+            || cc2538_state == CC2538_STATE_TX_ACK) {

How do `CC2538_STATE_READY` and `CC2538_STATE_TX_ACK` correspond with RX_ON?

> +    cc2538_state = CC2538_STATE_READY;
+    RFCORE_XREG_FRMCTRL0 &= ~CC2538_FRMCTRL0_RX_MODE_DIS;
+    res = cc2538_cca_status;

What's happening here?
Please leave a comment. 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/16821#pullrequestreview-754500868
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210914/9526334d/attachment.htm>


More information about the notifications mailing list