[riot-notifications] [RIOT-OS/RIOT] makefiles/docker.inc.mk: pass PARTICLE_MONOFIRMWARE to docker env vars (#16857)

Dylan Laduranty notifications at github.com
Wed Sep 15 15:57:50 CEST 2021



<!--
The RIOT community cares a lot about code quality.
Therefore, before describing what your contribution is about, we would like
you to make sure that your modifications are compliant with the RIOT
coding conventions, see https://github.com/RIOT-OS/RIOT/wiki/Coding-conventions.
-->

### Contribution description

This PR allows to pass `PARTICLE_MONOFIRMWARE` to `DOCKER_ENV_VARS`
This will allow the generation of the bin-checksummed file needed by `dfu-util` flashtool and thus allow to flash the all particle-based board with RUN_IN_DOCKER=1

### Testing procedure

<!--
Details steps to test your contribution:
- which test/example to compile for which board and is there a 'test' command
- how to know that it was not working/available in master
- the expected success test output
-->
You can test it without owning the hardware.
`make BUILD_IN_DOCKER=1 BOARD=particle-xenon PARTICLE_MONOFIRMWARE=1 -C examples/hello-world clean `
`make BUILD_IN_DOCKER=1 BOARD=particle-xenon PARTICLE_MONOFIRMWARE=1 -C examples/hello-world flash `

On master, the .bin-checksummed isn't generated (check the output of `examples/hello-world/bin/particle-xenon`) Since this file is required to flash through dfu-util, flashing part fails.
With this PR, the file is generated and dfu-util try to flash the board

### Issues/PRs references
Fixes #16749


You can view, comment on, or merge this pull request online at:

  https://github.com/RIOT-OS/RIOT/pull/16857

-- Commit Summary --

  * makefiles/docker.inc.mk: pass PARTICLE_MONOFIRMWARE to docker env vars

-- File Changes --

    M makefiles/docker.inc.mk (1)

-- Patch Links --

https://github.com/RIOT-OS/RIOT/pull/16857.patch
https://github.com/RIOT-OS/RIOT/pull/16857.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/16857
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210915/6d21bc0a/attachment.htm>


More information about the notifications mailing list