[riot-notifications] [RIOT-OS/RIOT] .murdock: Add nucleo boards to kconfig test (#16845)
notifications at github.com
Wed Sep 15 16:30:58 CEST 2021
Hmmm so here are the issues I see with this PR:
- The nucleo-wl55jc does not have any clock configurations for Kconfig
- We are using `BOARD_HAS_HSE` though it may be better to conform to the `HAVE_*` semantics
- The config of the `BOARD_HAS_HSE` is defined in the `common/stm32/kconfig` and I somehow think the definitions would better be in the Kconfig.clk or something, especially if we use the `HAVE_*` semantics
- Also I am wondering if the nucleo-w* boards should be bringing in a more well defined common (ie nucleo64) or something, that would have to be verified with the board.
It might be good to get an opinion from @aabadie regarding from BOARD_HAS_HSE to HAVE_CLK_HSE or something...
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the notifications