[riot-notifications] [RIOT-OS/RIOT] dist/tools: use f-strings where possible (#16867)

Martine Lenders notifications at github.com
Fri Sep 17 11:36:25 CEST 2021

The RIOT community cares a lot about code quality.
Therefore, before describing what your contribution is about, we would like
you to make sure that your modifications are compliant with the RIOT
coding conventions, see https://github.com/RIOT-OS/RIOT/wiki/Coding-conventions.

### Contribution description
In current master `tools-test` [fails](https://github.com/RIOT-OS/RIOT/runs/3629809579), due to pylint checking for f-strings in `backport_pr` and `compile_and_test_for_board` with its latest version. This uses f-strings in those scripts whereever possible.

With this change we effectively drop Python <=3.5 support for these scripts. As python 3.5 is EOL since September 2015, I think that is acceptable (and as far as I know these scripts are not used on some out-dated nodes in our CI infrastructure).
Put here the description of your contribution:
- describe which part(s) of RIOT is (are) involved
- if it's a bug fix, describe the bug that it solves and how it is solved
- you can also give more information to reviewers about how to test your changes

### Testing procedure
- `tox` should now pass again for both tests (`cd <scriptdir>; tox`).
- both scripts should have the same output in master and this PR.
Details steps to test your contribution:
- which test/example to compile for which board and is there a 'test' command
- how to know that it was not working/available in master
- the expected success test output

### Issues/PRs references
Examples: Fixes #1234. See also #5678. Depends on PR #9876.

Please use keywords (e.g., fixes, resolve) with the links to the issues you
resolved, this way they will be automatically closed when your pull request
is merged. See https://help.github.com/articles/closing-issues-using-keywords/.

You can view, comment on, or merge this pull request online at:


-- Commit Summary --

  * dist/tools/backport_pr: use f-strings where possible
  * dist/tools/compile_and_test_for_board: use f-strings where possible

-- File Changes --

    M dist/tools/backport_pr/backport_pr.py (64)
    M dist/tools/compile_and_test_for_board/compile_and_test_for_board.py (30)
    M dist/tools/compile_and_test_for_board/tests/test_compile_and_test_for_board.py (2)

-- Patch Links --


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210917/5fed7c22/attachment.htm>

More information about the notifications mailing list