[riot-notifications] [RIOT-OS/RIOT] cpu/nrf52: initial kconfig modeling (no netif) (#16837)

Francisco notifications at github.com
Sun Sep 19 16:16:35 CEST 2021


@fjmolinas commented on this pull request.



> +choice
+    bool "Backend"
+    depends on MODULE_NETDEV_DEFAULT
+    default NRF802154
+    default NRFBLE
+
+config NRF802154
+    bool "nrf802154"
+    select MODULE_NRF802154
+
+config NRFBLE
+    bool "nrfble"
+    select MODULE_NRFBLE
+
+config NRFMIN
+    bool "nrfmin"
+    select MODULE_NRFMIN
+
+endchoice


>     * This should probably be in `cpu/nrf52`

Ups, yes of course.
 
>     * I think we should define an aux symbol for this radio (e.g NRF52_RADIO) that declares a feature (HAVE_NRF52RF_RADIO). This one can be set to `y` if MODULE_NETDEV_DEFAULT is present. Then, the backend selection depends on HAVE_NRF52_RADIO.

I don't understand why the auxiliary symbol needs to be used seems like a weird dependency. I don't see why `HAVE_NRF52RF_RADIO` would depend on `NETDEV_DEFAULT` either, if its a featuer it should allways be selected. Maybe if you can add a code snipped I can understand better your suggestion.


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/16837#discussion_r711751678
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210919/b8328784/attachment-0001.htm>


More information about the notifications mailing list