[riot-notifications] [RIOT-OS/RIOT] build system: add machine-readable RIOT_VERSION_CODE macro (#16765)

Martine Lenders notifications at github.com
Mon Sep 20 20:56:52 CEST 2021


@miri64 commented on this pull request.



> @@ -28,7 +28,7 @@ static void test_kernel_version(void)
     uint16_t mayor, minor, patch, extra;
 
     TEST_ASSERT(RIOT_VERSION_CODE);
-    TEST_ASSERT(RIOT_VERSION_CODE > KERNEL_VERSION(2020, 7, 1, 0));
+    TEST_ASSERT(RIOT_VERSION_CODE > KERNEL_VERSION(2017, 1, 3, 0));
     TEST_ASSERT(RIOT_VERSION_CODE < KERNEL_VERSION(2080, 10, 2, 0));

That would also be better for the test case here. Just reading the test, 2017.01 seems somewhat random? Why not use 0.0?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/16765#discussion_r712432707
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210920/2e14afed/attachment.htm>


More information about the notifications mailing list