[riot-notifications] [RIOT-OS/RIOT] cpu/native: make use of stdio_read() / stdio_write() (#16822)

Karl Fessel notifications at github.com
Mon Sep 20 22:47:57 CEST 2021


@kfessel commented on this pull request.

With comments by miri64 and kaspar030, i think the non-blocking read is out of scope for this PR. I tried something with async_read  in stdio_native and this patch helped in doing so.

This PR also changes how stdio works into the form someone reading the directory structure in native would expect it to do.

Lets avoid the scope creep. :rocket: 

> +            ssize_t res = stdio_write(iov->iov_base, iov->iov_len);
+            iov++;

I think `res` needs to be compared to `iov->iov_len` before advancing to next element,
(there are stdio implementations in RIOT that might not write everything given to them (avoid blocking))

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/16822#pullrequestreview-759073718
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210920/d057c768/attachment.htm>


More information about the notifications mailing list