[riot-notifications] [RIOT-OS/RIOT] build system: add machine-readable RIOT_VERSION_CODE macro (#16765)

Martine Lenders notifications at github.com
Tue Sep 21 09:50:02 CEST 2021


@miri64 commented on this pull request.



> + * @param[in]   a   Mayor version of the release
+ * @param[in]   b   Minor version of the release
+ * @param[in]   c   Patch level of the release
+ * @param[in]   d   Extraversion, user defined

This parameter names could have some more spelling names.

> @@ -475,7 +475,7 @@ endif
 
 # set some settings useful for continuous integration builds
 ifeq ($(RIOT_CI_BUILD),1)
-    RIOT_VERSION ?= buildtest
+    RIOT_VERSION ?= $(shell git describe --abbrev=0)

> I don't like forcing the riot version string define into some format that is based on git or anything.
> Linux doesn't do that either, they have manual version defines.

Welp, setting it to

```suggestion
    RIOT_VERSION ?= 0000.00
```

Would be independent of git :-).

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/16765#pullrequestreview-759406948
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210921/64272e63/attachment.htm>


More information about the notifications mailing list