[riot-notifications] [RIOT-OS/RIOT] cpu/native: make use of stdio_read() / stdio_write() (#16822)

Karl Fessel notifications at github.com
Tue Sep 21 18:06:34 CEST 2021


@kfessel commented on this pull request.



> +            size_t offset = 0;
+            while (iov->iov_len > offset) {
+                ssize_t res = stdio_write((void *)((uintptr_t)iov->iov_base + offset),
+                                          iov->iov_len - offset);
+                if (res < 0) {
+                    return res;
+                }
+                offset += res;
+            }
+            r += offset;

i would avoid the inner loop:

```suggestion
                ssize_t res = stdio_write((void *)((uintptr_t)iov->iov_base),
                                          iov->iov_len);
                if( res >= 0 ){
                    r += res; 
                }
                if (res <  iov->iov_len) {
                    return (r>=0) ? r : res;
                }
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/16822#pullrequestreview-759957819
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210921/71b6c8c4/attachment.htm>


More information about the notifications mailing list