[riot-notifications] [RIOT-OS/RIOT] cpu/native: make use of stdio_read() / stdio_write() (#16822)

Karl Fessel notifications at github.com
Wed Sep 22 17:13:48 CEST 2021


@kfessel commented on this pull request.



> +                errno = res;
+                return -1;

`*write` should already have set `errno` -at least in case `real_write` is called (default)- the return value should not be an ERRNO but according to standard is -1 (in case of failure)
```suggestion
                return res;
```

> +                errno = res;
+                return -1;

`return -1` would also be ok but in that case we need may have another `set return register = -1` instruction 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/16822#pullrequestreview-761053118
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210922/c814d5b3/attachment.htm>


More information about the notifications mailing list