[riot-notifications] [RIOT-OS/RIOT] .murdock: Add nucleo boards to kconfig test (#16845)

MrKevinWeiss notifications at github.com
Thu Sep 23 13:14:11 CEST 2021


@MrKevinWeiss commented on this pull request.



> @@ -23,6 +23,8 @@ config BOARD_NUCLEO_L4R5ZI
     select HAS_PERIPH_TIMER
     select HAS_PERIPH_UART
 
+    select MODULE_PERIPH_LPUART if MODULE_STDIO_UART && HAS_PERIPH_LPUART

The && doesn't need to be added as the board config is where the `HAS_PERIPH_LPUART` is. 
I wanted to add that to make it a bit more verbose as it is a requirement, though the requirement is both given and consumed within the one symbol.

`PERIPH_UART` must be selected anyway for the `MODULE_PERIPH_LPUART` to even be exposed...

Would that be an additional requirement, or, since it is 'if'ed out it would throw an error if the `MODULE_PERIPH_LPUART` was trying to be selected but there was no `MODULE_PERIPH_UART`?

and I guess this is where things get confusing. 

MODULE_PERIPH_LPUART depends on MODULE_PERIPH_UART
MODULE_STDIO_UART selects MODULE_PERIPH_UART
therefore if MODULE_STDIO_UART selects MODULE_PERIPH_LPUART, we can assume MODULE_PERIPH_UART is selected.

However, if, for some reason, MODULE_STDIO_UART no longer selects MODULE_PERIPH_UART that would break that dependency.

I don't think there is a super clean solution.

I can remove the `HAS_PERIPH_LPUART` as it is declared above and this should only exist in boards that PERIPH_LPUART anyways and we can trust MODULE_STDIO_UART to being in all required modules and dependencies?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/16845#discussion_r714693434
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210923/b39f7931/attachment.htm>


More information about the notifications mailing list