[riot-notifications] [RIOT-OS/RIOT] BUILD_IN_DOCKER ignores USEMODULE (#14504)

Gaëtan Harter notifications at github.com
Thu Sep 23 15:17:45 CEST 2021


>From memory only and without re-checking the current state.

Indeed your first solution is the simplest one and leaves it to the user.

For the second option, the "clean" way of doing it, is moving the USEMODULE that are in the application module in dedicated `Makefile.deps` and parse them at the dependency time. (same for a Makefile.include IIRC if there should be configuration depending on the dependencies).
I did not do it as refactoring the features and moving dependency parsing before parsing Makefile.include took ages to get reviewed. I may not even have finished it myself, I am not sure.

For the third option, not sure if there are still any side-effects possible for this.
It was at the beginning not possible because of the dependencies/cpu/board/Makefile.include inverse parsing order.
For USEMODULE it could be ok now that dependencies are parsed first if the application makefiles do not do weird things.
But not be for all variables.

For BINDIRBASE and all these variables, I did some poc removing the "override" and ":= abspath" replaced by a check if the variables were absolute but I think never went to proposing the command line API change
https://github.com/cladmi/RIOT/commits/wip/pr/make/remove_var_override

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/issues/14504#issuecomment-925808208
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210923/8810a075/attachment.htm>


More information about the notifications mailing list