[riot-notifications] [RIOT-OS/RIOT] makefiles/suit.base.inc.mk: don't clean existing keys (#16893)

Francisco notifications at github.com
Mon Sep 27 08:30:03 CEST 2021


> Hm. I'm not convinced, now this might re-create the key when doing codesize comparisons (with RIOT_CI_BUILD).

If it does it would only be in BINDIR, code size would not change, how often is `RIOT_CI_BUILD` in none ci builds? If someone stored their key in `BINDIR` then expect them to be cleaned. The check could also be conditioned on the keys being in BINDIR.

>  Maybe key generation should be manual in every case? Like, with a "suit/generate_key" target?

There is already one BTW `suit/genkey`.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/16893#issuecomment-927571511
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210926/37738514/attachment.htm>


More information about the notifications mailing list