[riot-notifications] [RIOT-OS/RIOT] build system: add fallback for RIOT_VERSION_CODE (#16895)

Martine Lenders notifications at github.com
Mon Sep 27 11:59:09 CEST 2021


@miri64 requested changes on this pull request.



> @@ -530,7 +531,8 @@ endif
 
 # Generate machine readable RIOT VERSION macro
 RIOT_VERSION_CODE ?= $(shell echo ${RIOT_VERSION} | \
-                      sed -E 's/([0-9]+).([0-9]+).?([0-9]+)?.*/RIOT_VERSION_NUM\\\(\1,\2,0\3,${RIOT_EXTRAVERSION}\\\)/')
+                      sed -E 's/([0-9]+).([0-9]+).?([0-9]+)?.*/RIOT_VERSION_NUM\\\(\1,\2,0\3,${RIOT_EXTRAVERSION}\\\)/' | \

```suggestion
                      sed -E 's/([0-9]+)\.([0-9]+)\.?([0-9]+)?.*/RIOT_VERSION_NUM\\\(\1,\2,0\3,${RIOT_EXTRAVERSION}\\\)/' | \
```

Otherwise things like `6035-HEAD` also match (as it is currently the case in the `release-tests`, since `.` resolves to "any character" ;-)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/16895#pullrequestreview-764073941
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210927/a3e23a64/attachment.htm>


More information about the notifications mailing list