[riot-notifications] [RIOT-OS/RIOT] gnrc/ipv6_auto_subnets: relax topology requirements (#16750)

Martine Lenders notifications at github.com
Tue Sep 28 13:10:18 CEST 2021


@miri64 requested changes on this pull request.



> +    uint8_t version : 4;    /**< version number, should be 0 */
+    uint8_t flags   : 4;    /**< flags, unused, should be 0 */

We don't like bit fields because of reasons (honestly can't why remember, but that's why I used flags and bit masks, e.g., in the GNRC headers).

> +    uint8_t version : 4;    /**< version number, should be 0 */
+    uint8_t flags   : 4;    /**< flags, unused, should be 0 */

Also, do you mean “should” or “must”?

> +    uint8_t version : 4;    /**< version number, should be 0 */
+    uint8_t flags   : 4;    /**< flags, unused, should be 0 */

And the flags are “reserved for future use”, not unused, right?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/16750#pullrequestreview-765293722
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210928/b85db3c6/attachment.htm>


More information about the notifications mailing list