[riot-notifications] [RIOT-OS/RIOT] cpu/nrf52: initial kconfig modeling (no netif) (#16837)

Leandro Lanzieri notifications at github.com
Tue Sep 28 13:37:06 CEST 2021


@leandrolanzieri commented on this pull request.



> +config MODULE_NRF802154
+    bool "Implementation of the IEEE 802.15.4 for nRF52 radio"
+    depends on HAS_RADIO_NRF802154
+    depends on HAS_PERIPH_TIMER
+    select MODULE_LUID
+    select MODULE_PERIPH_TIMER

I think this is missing some netdev ieee802154 dependencies, as it fails to link when enabled. @jia200x may shed some light?

> @@ -0,0 +1,49 @@
+# Copyright (c) 2021 Inria
+#
+# This file is subject to the terms and conditions of the GNU Lesser
+# General Public License v2.1. See the file LICENSE in the top level
+# directory for more details.
+#
+

I think I like the idea of having this shared among nrf CPUs, I was a bit lost with the different files in the beginning , is it necessary that `Kconfig.net` includes `"$(RIOTCPU)/nrf52/radio/Kconfig"` ? And that in turn includes this? Would it work including this one directly?

> @@ -15,6 +15,7 @@ config CPU_FAM_NRF52
     select HAS_CORTEXM_MPU
     select HAS_CPU_NRF52
     select HAS_PERIPH_I2C_RECONFIGURE
+    select HAVE_NRF5X_RADIO

What about `HAS_RADIO_NRF802154` `select`ing this instead?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/16837#pullrequestreview-765314101
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210928/3544a141/attachment-0001.htm>


More information about the notifications mailing list