[riot-notifications] [RIOT-OS/RIOT] cpu/riscv: model Kconfig (#16909)

Leandro Lanzieri notifications at github.com
Tue Sep 28 17:09:31 CEST 2021


@leandrolanzieri commented on this pull request.



> +choice LIBC_IMPLEMENTATION
+    bool "Libc implementation"
+    depends on TEST_KCONFIG
+    default MODULE_NEWLIB if USE_LIBC_NEWLIB
+    default MODULE_PICOLIBC if USE_LIBC_PICOLIBC

I have an alternative proposal for this one, which uses less symbols:
```
choice LIBC_IMPLEMENTATION
    bool "Libc implementation"
    depends on TEST_KCONFIG

config MODULE_NEWLIB
    bool "NewLib"

config MODULE_PICOLIBC
    bool "Picolibc"

endchoice
```

The default can be chosen in `riscv_common/Kconfig` as:
```
choice LIBC_IMPLEMENTATION
    default MODULE_NEWLIB

endchoice
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/16909#pullrequestreview-765588158
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210928/0b10fc02/attachment.htm>


More information about the notifications mailing list