[riot-notifications] [RIOT-OS/RIOT] cpu/efm32: model kconfig (#16912)

Francisco notifications at github.com
Wed Sep 29 09:50:57 CEST 2021


@fjmolinas commented on this pull request.

Thanks for this! Looks good, haven't looked at menuconfig yet..

> @@ -33,3 +33,10 @@ ifeq (1,$(EFM32_LEUART_ENABLED))
 endif
 
 include $(RIOTCPU)/cortexm_common/Makefile.features
+
+# Add efm32 configurations after including cortexm_common so efm32 takes precendence
+# This configuration enables modules that are only available when using Kconfig
+# module modelling
+ifeq (1, $(TEST_KCONFIG))

```suggestion
ifeq (1,$(TEST_KCONFIG))
```

> +# include makefiles utils tools
+include $(RIOTMAKE)/utils/strings.mk

Isn't this available early on?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/16912#pullrequestreview-766318460
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210929/698d206e/attachment-0001.htm>


More information about the notifications mailing list