[riot-notifications] [RIOT-OS/RIOT] tests/thread_float: improve and add script (#16901)

Marian Buschsieweke notifications at github.com
Wed Sep 29 22:47:40 CEST 2021


@maribu commented on this pull request.



> +    if (first_thread == 1):
+        assertAlmostEqual(float(first_result), 141.44372894635987)
+        assertAlmostEqual(float(second_result), 141.44372894635987)
+    else:
+        assertAlmostEqual(float(second_result), 141.44372894635987)
+        assertAlmostEqual(float(first_result), 141.44372894635987)

Thanks for pointing out the `zip()` loop. I decided to just recompute the expected result in python, since the duration of the test won't be affected by this (bound by the flops of the MCU or the speed of the UART / USB CDC ECM). This will also get rid of the magic numbers.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/16901#discussion_r718872843
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210929/8250f27f/attachment.htm>


More information about the notifications mailing list