<p><b>@kYc0o</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/RIOT-OS/RIOT/pull/8895#discussion_r181802164">pkg/libcose/Makefile.libcose</a>:</p>
<pre style='color:#555'>> @@ -0,0 +1,3 @@
+MODULE := libcose
</pre>
<p>My comment it's not related to the fact if it works or not. I know both work, but not both are correct. You can have a hint <a href="https://stackoverflow.com/questions/448910/what-is-the-difference-between-the-gnu-makefile-variable-assignments-a/448973" rel="nofollow">here</a>. If there are places where this is wrongly used, we might correct them in follow up PRs. I just want to have a clean PR here.</p>
<p>So, I'd say the correct way to do is <code>MODULE = libcose</code> and <code>SUBMODULES := 1</code>. In case I misunderstood the usages, can <a class="user-mention" data-hovercard-user-id="241401" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/cladmi">@cladmi</a> give us a hand here?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/RIOT-OS/RIOT/pull/8895#discussion_r181802164">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AEn7YGQAKkjLbi3RZwj1fc0tGRBGT-1Lks5tpMXugaJpZM4TKE8B">mute the thread</a>.<img src="https://github.com/notifications/beacon/AEn7YBY-wKeFg9xJWj5CnMzNtO-WZitAks5tpMXugaJpZM4TKE8B.gif" height="1" width="1" alt="" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/RIOT-OS/RIOT/pull/8895#discussion_r181802164"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/RIOT-OS/RIOT","title":"RIOT-OS/RIOT","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/RIOT-OS/RIOT"}},"updates":{"snippets":[{"icon":"PERSON","message":"@kYc0o commented on #8895"}],"action":{"name":"View Pull Request","url":"https://github.com/RIOT-OS/RIOT/pull/8895#discussion_r181802164"}}}</script>