<p>Hm. I can see that this is very useful, but it feels very macro-hacky, and also like a generically useful mechanism is put into pm_layered.</p>
<p>Could you live with call-site addresses (instead of names)? Maybe <code>LOG_DEBUG("%s: called from %p, ...\n", __func__, __builtin_return_address(), ...);</code> at the top of pm_block/unblock serves the same purpose, with less hackery. The LOG_DEBUG level is below default (e.g., silent by default). It should be possible to enable that level just for pm_layered by adding "CFLAGS += -DLOG_LEVEL=LOG_DEBUG" to <code>sys/pm_layered/Makefile</code>.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/RIOT-OS/RIOT/pull/10372#issuecomment-438836828">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AEn7YMl7wzyAGklxiY6UkTFgnhV2lUC0ks5uvJQ_gaJpZM4YZwGX">mute the thread</a>.<img src="https://github.com/notifications/beacon/AEn7YABq01wdu72Qt2eLGvzkfPxKbuiTks5uvJQ_gaJpZM4YZwGX.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/RIOT-OS/RIOT","title":"RIOT-OS/RIOT","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/RIOT-OS/RIOT"}},"updates":{"snippets":[{"icon":"PERSON","message":"@kaspar030 in #10372: Hm. I can see that this is very useful, but it feels very macro-hacky, and also like a generically useful mechanism is put into pm_layered.\r\n\r\nCould you live with call-site addresses (instead of names)? Maybe ```LOG_DEBUG(\"%s: called from %p, ...\\n\", __func__, __builtin_return_address(), ...);``` at the top of pm_block/unblock serves the same purpose, with less hackery. The LOG_DEBUG level is below default (e.g., silent by default). It should be possible to enable that level just for pm_layered by adding \"CFLAGS += -DLOG_LEVEL=LOG_DEBUG\" to ```sys/pm_layered/Makefile```."}],"action":{"name":"View Pull Request","url":"https://github.com/RIOT-OS/RIOT/pull/10372#issuecomment-438836828"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/RIOT-OS/RIOT/pull/10372#issuecomment-438836828",
"url": "https://github.com/RIOT-OS/RIOT/pull/10372#issuecomment-438836828",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "Re: [RIOT-OS/RIOT] WIP: pm_layered: print block/unblock (#10372)",
"sections": [
{
"text": "",
"activityTitle": "**Kaspar Schleiser**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@kaspar030",
"facts": [

]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"RIOT-OS/RIOT\",\n\"issueId\": 10372,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}"
}
]
},
{
"name": "Close pull request",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"PullRequestClose\",\n\"repositoryFullName\": \"RIOT-OS/RIOT\",\n\"pullRequestId\": 10372\n}"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/RIOT-OS/RIOT/pull/10372#issuecomment-438836828"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 409403799\n}"
}
],
"themeColor": "26292E"
}
]</script>